-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orca: fix the delimiter of the native http parser #37724
Conversation
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
This is a behavior change. But the orca feature should not be widely used. I am thinking should we change it directly, or add a runtime flag, or to support both ":" and "=" as delimiters (although may not match the document). cc @alyssawilk |
/retest |
This change will probably be needed to be updated in many docs. |
I forget to push the change log. Actually, this PR fixed the implementation based on the design document. In the design document, |
…ix-bug-of-orca-parser
Thanks for catching this, agreed the design calls for '=' as the delimiter. However, this PR is backwards incompatible for existing users, so supporting both ':' and '=' would be preferable IMO. |
Then we need to ensure both |
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
Nice catch. Thanks, @wbpcode ! |
Looks good to me, thank you for fixing this in backwards compatible way! |
…ix-bug-of-orca-parser
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Small nit, but otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Commit Message: orca: fix the delimiter of the native http parser
Additional Description:
This should also be cherry-pick to 1.32 to fix this problem.
The previous ORCA parser will use
:
as the delimiter of key/value pair in the native HTTP report. This is wrongbased on the design document. The correct delimiter should be
=
. This change fixes the delimiter to=
.See #6614 and related documents for more details.
https://docs.google.com/document/d/1NSnK3346BkBo1JUU3I9I5NYYnaJZQPt8_Z_XCBCI3uA/edit?tab=t.0
Risk Level: n/a.
Testing: n/a.
Docs Changes: n/a.
Release Notes: added.