srds: permit dynamic SRDS resources to contain inline RDS configuration #36703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugene Chan <[email protected]>
Signed-off-by: Eugene Chan <[email protected]>
|
Thanks this makes sense. Can you add a release note please? /wait |
Signed-off-by: Eugene Chan <[email protected]>
|
/retest |
mattklein123
previously approved these changes
Oct 22, 2024
|
/retest |
Signed-off-by: Eugene Chan <[email protected]>
auto-merge was automatically disabled
October 22, 2024 22:47
Head branch was pushed to by a user without write access
|
Ah, this is probably going to conflict with my other PR. I'll bring this out of draft when main is merged. |
|
/retest |
mattklein123
approved these changes
Oct 31, 2024
KBaichoo
pushed a commit
that referenced
this pull request
Nov 4, 2024
An extraneous if block was introduced merging #36702 into #36703. We're checking this condition above in L282, so this block should never be executed. Commit Message: remove a redundant if block Additional Description: n/a Risk Level: low Testing: existing CI Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Eugene Chan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: permit dynamic SRDS resources to contain inline RDS configuration
Additional Description:
Currently, scoped_routes specified inline into the HCM may only contain inline route_configuration, and scoped_routes that are delivered via SRDS may only contain route_configuration_name which is used to open an RDS subscription. This PR permits resources delivered via SRDS to contain inline RouteConfiguration, forgoing the RDS subscription.
Risk Level: low
Testing: CI & integration
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a