Skip to content

Commit

Permalink
srds: remove a redundant if block (#36944)
Browse files Browse the repository at this point in the history
An extraneous if block was introduced merging #36702 into #36703. We're
checking this condition above in L282, so this block should never be
executed.

Commit Message: remove a redundant if block
Additional Description: n/a
Risk Level: low
Testing: existing CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Eugene Chan <[email protected]>
  • Loading branch information
pianiststickman authored Nov 4, 2024
1 parent d97f5a7 commit ce7202f
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions source/common/router/scoped_rds.cc
Original file line number Diff line number Diff line change
Expand Up @@ -312,11 +312,6 @@ absl::StatusOr<bool> ScopedRdsConfigSubscription::addOrUpdateScopes(
if (scoped_route_config.route_configuration_name().empty()) {
return absl::InvalidArgumentError("route_configuration_name is empty.");
}
if (const auto& scope_info_iter = scoped_route_map_.find(scope_name);
scope_info_iter != scoped_route_map_.end() &&
scope_info_iter->second->configHash() == MessageUtil::hash(scoped_route_config)) {
continue;
}
rds.set_route_config_name(scoped_route_config.route_configuration_name());
std::unique_ptr<RdsRouteConfigProviderHelper> rds_config_provider_helper;
if (scoped_route_config.on_demand() == false) {
Expand Down

0 comments on commit ce7202f

Please sign in to comment.