Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: removed automatical route refreshment and add a foreign function to clear the route cache #36671

Merged

fix format

87a3a55
Select commit
Loading
Failed to load commit list.
Merged

wasm: removed automatical route refreshment and add a foreign function to clear the route cache #36671

fix format
87a3a55
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/ASAN skipped Oct 23, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/36671/main@87a3a55)

wbpcode @wbpcode 87a3a55 #36671 merge main@5e94ec7

wasm: removed automatical route refreshment and add a foreign function to clear the route cache

Commit Message: wasm: removed automatical route refreshment and add a foreign function to clear the route cache

Additional Description:

Here are the reasons to do this change:

  1. It make it's impossible to only mofify the host or path or some headers but don't effect the route result.
  2. Basically, refreshing route is not encouraged. Even the filters (ext_authz, jwt_authz, ext_proc, etc) who acutally need or want to clear the route cache will also provide a flag (and basically default to false) to control the behavior.
  3. Refreshing route have big effect to the traffic and should only be done explicitly (code or configurations), we should never change it implicitly.

Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

Environment

Request variables

Key Value
ref 17b5e97
sha 87a3a55
pr 36671
base-sha 5e94ec7
actor wbpcode @wbpcode
message wasm: removed automatical route refreshment and add a foreign function to clear the route cache...
started 1729651683.515632
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true