wasm: removed automatical route refreshment and add a foreign function to clear the route cache #36671
+191
−29
CI (Envoy) / Mobile/Perf
skipped
Oct 23, 2024 in 0s
Check was skipped
This check was not triggered in this CI run
Details
Request (pr/36671/main@87a3a55)
@wbpcode 87a3a55
#36671 merge
main@5e94ec7
wasm: removed automatical route refreshment and add a foreign function to clear the route cache
Commit Message: wasm: removed automatical route refreshment and add a foreign function to clear the route cache
Additional Description:
Here are the reasons to do this change:
- It make it's impossible to only mofify the host or path or some headers but don't effect the route result.
- Basically, refreshing route is not encouraged. Even the filters (ext_authz, jwt_authz, ext_proc, etc) who acutally need or want to clear the route cache will also provide a flag (and basically default to
false
) to control the behavior.- Refreshing route have big effect to the traffic and should only be done explicitly (code or configurations), we should never change it implicitly.
Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.
Environment
Request variables
Key | Value |
---|---|
ref | 17b5e97 |
sha | 87a3a55 |
pr | 36671 |
base-sha | 5e94ec7 |
actor | @wbpcode |
message | wasm: removed automatical route refreshment and add a foreign function to clear the route cache... |
started | 1729651683.515632 |
target-branch | main |
trusted | false |
Build image
Container image/s (as used in this CI run)
Key | Value |
---|---|
default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
Key | Value |
---|---|
major | 1 |
minor | 33 |
patch | 0 |
dev | true |
Loading