Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto util: change the input string ref to string view #36525

Merged

fix building

c8eb56c
Select commit
Loading
Failed to load commit list.
Merged

proto util: change the input string ref to string view #36525

fix building
c8eb56c
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Android skipped Oct 10, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/36525/main@c8eb56c)

wbpcode @wbpcode c8eb56c #36525 merge main@17d5942

proto util: change the input string ref to string view

Commit Message: proto util: change the input string ref to string view
Additional Description:

absl::string_view is better thanconst string& in most cases to avoid unnecessary copy.

Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

Environment

Request variables

Key Value
ref a6bb6ee
sha c8eb56c
pr 36525
base-sha 17d5942
actor wbpcode @wbpcode
message proto util: change the input string ref to string view...
started 1728543398.396198
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true