proto util: change the input string ref to string view #36525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangbaiping <[email protected]>
Signed-off-by: wangbaiping <[email protected]>
|
/retest |
Stevenjin8
pushed a commit
to Stevenjin8/envoy
that referenced
this pull request
Oct 10, 2024
) Commit Message: proto util: change the input string ref to string view Additional Description: `absl::string_view` is better than`const string&` in most cases to avoid unnecessary copy. Risk Level: low. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wangbaiping <[email protected]> Signed-off-by: Steven Jin Xuan <[email protected]>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Oct 17, 2024
) Commit Message: proto util: change the input string ref to string view Additional Description: `absl::string_view` is better than`const string&` in most cases to avoid unnecessary copy. Risk Level: low. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wangbaiping <[email protected]> Signed-off-by: Gustavo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: proto util: change the input string ref to string view
Additional Description:
absl::string_viewis better thanconst string&in most cases to avoid unnecessary copy.Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.