bazel/ci: Dont break caches with PATH
#35978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlax
changed the title
PATHPATH
phlax
changed the title
PATHPATH
Signed-off-by: Ryan Northey <[email protected]>
wbpcode
approved these changes
Sep 5, 2024
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 7, 2024
This reverts commit c85c065. Signed-off-by: Ryan Northey <[email protected]>
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Sep 10, 2024
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update .bazelrc to envoyproxy/envoy#35978 - Update ci/run_envoy_docker.sh to envoyproxy/envoy#35926 and envoyproxy/envoy#35660 - Update tools/gen_compilation_database.py to envoyproxy/envoy#36018 and envoyproxy/envoy#35811 - Update source/client/process_impl.cc to match interface change in envoyproxy/envoy#35912 Signed-off-by: Tom Zhang <[email protected]>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 26, 2024
setting `PATH` breaks caches by making otherwise hermetically equivalent builds build differently in different environments to make things worse `PATH` can be set in multiple places, so we break our own caches dep on how things are built Signed-off-by: Ryan Northey <[email protected]>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 26, 2024
setting `PATH` breaks caches by making otherwise hermetically equivalent builds build differently in different environments to make things worse `PATH` can be set in multiple places, so we break our own caches dep on how things are built Signed-off-by: Ryan Northey <[email protected]>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 26, 2024
setting `PATH` breaks caches by making otherwise hermetically equivalent builds build differently in different environments to make things worse `PATH` can be set in multiple places, so we break our own caches dep on how things are built Signed-off-by: Ryan Northey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting
PATHbreaks caches by making otherwise hermetically equivalent builds build differently in different environmentsto make things worse
PATHcan be set in multiple places, so we break our own caches dep on how things are built