Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo/ci: Shift publishing CI -> github #35660

Merged
merged 2 commits into from
Aug 28, 2024
Merged

repo/ci: Shift publishing CI -> github #35660

merged 2 commits into from
Aug 28, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Aug 10, 2024

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft August 10, 2024 11:52
@phlax phlax force-pushed the github-publish branch 4 times, most recently from 2cd0e3b to 0e8e00d Compare August 13, 2024 14:51
@phlax phlax changed the title [WIP] repo/ci: Shift publishing CI -> github repo/ci: Shift publishing CI -> github Aug 13, 2024
@phlax phlax marked this pull request as ready for review August 13, 2024 17:29
@phlax
Copy link
Member Author

phlax commented Aug 13, 2024

This wont pass CI until it lands as it relies on changes that are not made in a PR - its fairly well tested elsewhere

We need to address infra issues before we can land it - cc @krajshiva

phlax
phlax commented Aug 13, 2024
View reviewed changes
ci/do_ci.sh Outdated Show resolved Hide resolved
adisuissa
adisuissa reviewed Aug 14, 2024
View reviewed changes
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks!
I'll assign it to myself to prevent the slack-bot from nagging.
Do you think it makes sense to land this after the next sec-release? (just to reduce the chances of unexpected surprises)

ci/do_ci.sh Outdated Show resolved Hide resolved
@adisuissa adisuissa self-assigned this Aug 14, 2024
@phlax
Copy link
Member Author

phlax commented Aug 14, 2024

Do you think it makes sense to land this after the next sec-release? (just to reduce the chances of unexpected surprises)

should be unrelated as this is only change main - that said, some work is going to be needed in the sec repo (already, most likely)

main blocker here is there is not enough resources currently allocated

@adisuissa
Copy link
Contributor

Should this PR be in waiting mode?

@phlax
Copy link
Member Author

phlax commented Aug 16, 2024

yeah, until we resolve the infra issue

/wait

@phlax
remove-debugging
4e0f622 
Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member Author

phlax commented Aug 28, 2024

@adisuissa this one should be gtg - infra issue has been resolved i believe

@phlax phlax merged commit 2cfaf78 into envoyproxy:main Aug 28, 2024
38 of 39 checks passed
@phlax phlax mentioned this pull request Sep 3, 2024
Closed
@tomjzzhang tomjzzhang mentioned this pull request Sep 9, 2024
Merged
mum4k pushed a commit to envoyproxy/nighthawk that referenced this pull request Sep 10, 2024
@tomjzzhang
Update Envoy to fbc6ee2 (Sep 08, 2024) (#1219)
d8407d9 
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit.
- Update .bazelrc to envoyproxy/envoy#35978
- Update ci/run_envoy_docker.sh to envoyproxy/envoy#35926 and envoyproxy/envoy#35660
- Update tools/gen_compilation_database.py to envoyproxy/envoy#36018 and envoyproxy/envoy#35811
- Update source/client/process_impl.cc to match interface change in envoyproxy/envoy#35912

Signed-off-by: Tom Zhang <[email protected]>
phlax added a commit to phlax/envoy that referenced this pull request Sep 12, 2024
@phlax
repo/ci: Shift publishing CI -> github (envoyproxy#35660)
3ab9351 
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax added a commit that referenced this pull request Sep 12, 2024
@phlax
repo/ci: Shift publishing CI -> github (#35660)
e18208c 
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax added a commit to phlax/envoy that referenced this pull request Sep 12, 2024
@phlax
repo/ci: Shift publishing CI -> github (envoyproxy#35660)
368b9f9 
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax added a commit that referenced this pull request Sep 12, 2024
@phlax
repo/ci: Shift publishing CI -> github (#35660)
45bbeaf 
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax added a commit to phlax/envoy that referenced this pull request Sep 13, 2024
@phlax
repo/ci: Shift publishing CI -> github (envoyproxy#35660)
8d43268 
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax added a commit to phlax/envoy that referenced this pull request Sep 13, 2024
@phlax
repo/ci: Shift publishing CI -> github (envoyproxy#35660)
6c91143 
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax added a commit that referenced this pull request Sep 13, 2024
@phlax
repo/ci: Shift publishing CI -> github (#35660)
2c4f12b 
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax added a commit that referenced this pull request Sep 13, 2024
@phlax
repo/ci: Shift publishing CI -> github (#35660)
218ddef 
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisuissa adisuissa adisuissa left review comments

@ggreenway ggreenway ggreenway approved these changes

Assignees

@adisuissa adisuissa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phlax @adisuissa @ggreenway