Ensure every instance of StreamFilter and PassThroughFilter to contain only one copy of StreamFilterBase. #35341
CI (Envoy) / Envoy/Prechecks
skipped
Jul 31, 2024 in 0s
Check was skipped
This check was not triggered in this CI run
Details
Request (pr/35341/main@359cb8f)
359cb8f 
#35341 merge main@b0cc284
Ensure every instance of StreamFilter and PassThroughFilter to contain only one copy of StreamFilterBase.
Change Stream(Decode|Encode)Filter to inherit from StreamFilterBase virtually.
Move the default implementation of PassThrough(Decoder|Encode)Filter::onDestroy into StreamFilterBase.Commit Message: Ensure every instance of StreamFilter and PassThroughFilter to contain only one copy of Stream(Decode|Encode)Filter and StreamFilterBase.
Additional Description:
Risk Level: Medium
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
Environment
Request variables
| Key | Value |
|---|---|
| ref | 2422247 |
| sha | 359cb8f |
| pr | 35341 |
| base-sha | b0cc284 |
| actor | @wu-bin |
| message | Ensure every instance of StreamFilter and PassThroughFilter to contain only one copy of StreamFilterBase.... |
| started | 1722433393.003361 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 32 |
| patch | 0 |
| dev | true |
Loading