Ensure every instance of StreamFilter and PassThroughFilter to contain only one copy of StreamFilterBase. #35341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtually. Change PassThrough(Decoder|Encode)Filter to inherit from Stream(Decoder|Encode)Filter virtually. This ensures every instance of StreamFilter and PassThroughFilter contains only one copy of Stream(Decode|Encode)Filter and StreamFilterBase. Signed-off-by: Bin Wu <[email protected]>
wu-bin
changed the title
yanavlasov
reviewed
Jul 23, 2024
envoy/http/filter.h
Outdated
| @@ -857,7 +857,7 @@ class StreamFilterBase { | |||
| * onDestroy() invoked. Filters that cross-register as access log handlers receive log() before | |||
| * onDestroy(). | |||
| */ | |||
| virtual void onDestroy() PURE; | |||
| virtual void onDestroy() {} | |||
There was a problem hiding this comment.
Can you keep this method pure virtual if you add override onDestroy in the PassThroughFilter? Or is it causing more build errors than that?
There was a problem hiding this comment.
Thanks Yan, but I think if we do that, an existing class will not compile if
- It derives directly from
PassThroughDecoderFilterorPassThroughEncoderFilter, and - It doesn't override onDestroy, i.e. it relies on the empty implementation in
PassThroughDecoderFilterorPassThroughEncoderFilter.
There was a problem hiding this comment.
Did you try it? Can you post the compiler error, please?
There was a problem hiding this comment.
As discussed, I change to have 3 onDestroy implementations in PassThroughDecoderFilter, PassThroughEncoderFilter, and PassThroughFilter. PTAL.
|
/wait-any |
implementations in PassThroughDecoderFilter, PassThroughEncoderFilter and PassThroughFilter. Signed-off-by: Bin Wu <[email protected]>
yanavlasov
approved these changes
Aug 1, 2024
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
…n only one copy of StreamFilterBase. (envoyproxy#35341) Change Stream(Decode|Encode)Filter to inherit from StreamFilterBase virtually. Move the default implementation of PassThrough(Decoder|Encode)Filter::onDestroy into StreamFilterBase. --------- Signed-off-by: Bin Wu <[email protected]> Signed-off-by: Martin Duke <[email protected]>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
…n only one copy of StreamFilterBase. (envoyproxy#35341) Change Stream(Decode|Encode)Filter to inherit from StreamFilterBase virtually. Move the default implementation of PassThrough(Decoder|Encode)Filter::onDestroy into StreamFilterBase. --------- Signed-off-by: Bin Wu <[email protected]> Signed-off-by: asingh-g <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Stream(Decode|Encode)Filter to inherit from StreamFilterBase virtually.
Move the default implementation of PassThrough(Decoder|Encode)Filter::onDestroy into StreamFilterBase.
Commit Message: Ensure every instance of StreamFilter and PassThroughFilter to contain only one copy of Stream(Decode|Encode)Filter and StreamFilterBase.
Additional Description:
Risk Level: Medium
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]