Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: don't respond with FORMERR if message has ID 0 #35129

Merged
merged 6 commits into from
Jul 22, 2024

Merge remote-tracking branch 'upstream/main' into fix/dns-id-0-v1.27

b8ba668
Select commit
Loading
Failed to load commit list.
Merged

dns: don't respond with FORMERR if message has ID 0 #35129

Merge remote-tracking branch 'upstream/main' into fix/dns-id-0-v1.27
b8ba668
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/Publish and verify succeeded Jul 22, 2024 in 1h 7m 37s

Envoy/Publish and verify (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Envoy/Publish and verify (pr/35129/main@b8ba668)

Check started by

Request (pr/35129/main@b8ba668)

michaelbeaumont @michaelbeaumont b8ba668 #35129 merge main@ec2ab0c

dns: don't respond with FORMERR if message has ID 0

Commit Message:
dns: don't respond with FORMERR if message has ID 0

Additional Description:
0 is a valid ID according to RFC 1035

Risk Level:
Low

Testing:
./ci/run_envoy_docker.sh './ci/do_ci.sh dev'

Docs Changes:
N/A

Release Notes:
dns: don't respond with FORMERR if message has ID 0

Platform Specific Features: N/A

Fixes #35097

Environment

Request variables

Key Value
ref 1e7e762
sha b8ba668
pr 35129
base-sha ec2ab0c
actor michaelbeaumont @michaelbeaumont
message dns: don't respond with FORMERR if message has ID 0...
started 1721660289.717505
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true