dns: don't respond with FORMERR if message has ID 0 #35129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @michaelbeaumont, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
fix/dns-id-0-v1.27
branch
from
a2ee4d7 to
4a7f4b1
Compare
mattklein123
requested changes
Jul 10, 2024
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
fix/dns-id-0-v1.27
branch
from
06aa6e7 to
1e8f33c
Compare
|
LGTM modulo open comments and CI. Thanks for fixing this. |
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
fix/dns-id-0-v1.27
branch
from
22cb1f4 to
6469383
Compare
|
Could the current CI failures be unrelated to this change? Having a bit of trouble running them locally but they seem quite unlikely to be caused by this |
|
/retest |
slonka
approved these changes
Jul 15, 2024
|
/backport |
repokitteh-read-only
bot
added
the
backport/review
|
@yanjunxiang-google @mattklein123 anything still needed for this? it's starting to run into conflicts with Oh I just noticed this missed v1.31 :/ |
yanjunxiang-google
approved these changes
Jul 22, 2024
mattklein123
approved these changes
Jul 22, 2024
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
Commit Message: dns: don't respond with FORMERR if message has ID 0 Additional Description: 0 is a valid ID according to RFC 1035 Risk Level: Low Testing: `./ci/run_envoy_docker.sh './ci/do_ci.sh dev'` Docs Changes: N/A Release Notes: dns: don't respond with FORMERR if message has ID 0 Platform Specific Features: N/A Fixes envoyproxy#35097 Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Martin Duke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
dns: don't respond with FORMERR if message has ID 0
Additional Description:
0 is a valid ID according to RFC 1035
Risk Level:
Low
Testing:
./ci/run_envoy_docker.sh './ci/do_ci.sh dev'Docs Changes:
N/A
Release Notes:
dns: don't respond with FORMERR if message has ID 0
Platform Specific Features: N/A
Fixes #35097