Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: More JNI cleanup #34181

Merged
merged 1 commit into from
May 15, 2024

More JNI cleanup

6ff01c7
Select commit
Loading
Failed to load commit list.
Merged

mobile: More JNI cleanup #34181

More JNI cleanup
6ff01c7
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/Publish and verify skipped May 15, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/34181/main@6ff01c7)

fredyw @fredyw 6ff01c7 #34181 merge main@ece9170

mobile: More JNI cleanup

This PR cleans up the JNI code by removing the Envoy::JNI::Exception and Envoy::JNI::String and adds exceptionClear in the JniHelper so that everything behaves the same way without more going through many layers.

Risk Level: low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

Environment

Request variables

Key Value
ref a09817c
sha 6ff01c7
pr 34181
base-sha ece9170
actor fredyw @fredyw
message mobile: More JNI cleanup...
started 1715802238.161436
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 31
patch 0
dev true
View more details on CI (Envoy)