Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mobile: More JNI cleanup #34181

Merged
merged 1 commit into from
May 15, 2024
Merged

mobile: More JNI cleanup #34181

merged 1 commit into from
May 15, 2024

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented May 15, 2024

This PR cleans up the JNI code by removing the Envoy::JNI::Exception and Envoy::JNI::String and adds exceptionClear in the JniHelper so that everything behaves the same way without more going through many layers.

Risk Level: low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34181 was opened by fredyw.

see: more, trace.

@fredyw fredyw changed the title mobile: More JNI clean up mobile: More JNI cleanup May 15, 2024
@fredyw fredyw force-pushed the more_jni_cleanup branch from 10fe281 to dac6d52 Compare May 15, 2024 17:20
@fredyw
Copy link
Member Author

fredyw commented May 15, 2024

/retest

@fredyw fredyw force-pushed the more_jni_cleanup branch from dac6d52 to 381f786 Compare May 15, 2024 18:58
@fredyw
Copy link
Member Author

fredyw commented May 15, 2024

/retest

@fredyw
More JNI cleanup
6ff01c7 
Signed-off-by: Fredy Wijaya <[email protected]>
@fredyw fredyw force-pushed the more_jni_cleanup branch from 381f786 to 6ff01c7 Compare May 15, 2024 19:43
@fredyw fredyw marked this pull request as ready for review May 15, 2024 20:11
@fredyw
Copy link
Member Author

fredyw commented May 15, 2024

/assign @abeyad

@fredyw fredyw enabled auto-merge (squash) May 15, 2024 20:23
@fredyw fredyw merged commit 416cd42 into envoyproxy:main May 15, 2024
35 checks passed
@fredyw fredyw deleted the more_jni_cleanup branch May 15, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeyad abeyad abeyad approved these changes

@RyanTheOptimist RyanTheOptimist Awaiting requested review from RyanTheOptimist RyanTheOptimist is a code owner

@alyssawilk alyssawilk Awaiting requested review from alyssawilk alyssawilk is a code owner

Assignees

@abeyad abeyad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredyw @abeyad