Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getaddrinfo: retrying on eai_again #33307

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Apr 3, 2024

#33130 now with a fix for the shutdown race.

Risk Level: low
Testing: new tests
Docs Changes: n/a
Release Notes: inline
[Optional Runtime guard:] yes

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #33307 was opened by alyssawilk.

see: more, trace.

Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #33307 was opened by alyssawilk.

see: more, trace.

Signed-off-by: Alyssa Wilk <[email protected]>
@alyssawilk
Copy link
Contributor Author

bazel test --config=clang-tsan //test/common/integration:client_integration_test --test_arg=--gtest_filter=IpVersions/ClientIntegrationTest.InvalidDomain/IPv4_Http3Upstream --runs_per_test=1000
passes cleanly.

@alyssawilk alyssawilk marked this pull request as ready for review April 3, 2024 20:03
@alyssawilk alyssawilk requested a review from mattklein123 as a code owner April 3, 2024 20:03
@alyssawilk
Copy link
Contributor Author

/wait on CI - 10k didn't pass

@alyssawilk alyssawilk merged commit 057e642 into envoyproxy:main Apr 4, 2024
53 checks passed
alyssawilk added a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
* Reapply "getaddrinfo: retrying on eai_again (envoyproxy#33130)" (envoyproxy#33159)

Risk Level: low
Testing: new tests
Docs Changes: n/a
Release Notes: inline
[Optional Runtime guard:] yes

Signed-off-by: Alyssa Wilk <[email protected]>
@alyssawilk alyssawilk deleted the lock_fix branch June 25, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants