getaddrinfo: retrying on eai_again #33130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
abeyad
previously approved these changes
Mar 26, 2024
| @@ -157,6 +159,9 @@ class GetAddrInfoDnsResolver : public DnsResolver, public Logger::Loggable<Logge | |||
|
|
|||
| next_query = std::move(pending_queries_.front()); | |||
| pending_queries_.pop_front(); | |||
| if (reresolve && next_query->cancelled_) { | |||
There was a problem hiding this comment.
nit: it's probably not important, but do we need the reresolve condition here? In other words, shouldn't any next_query that is in the cancelled state be skipped? I realize the only way this can happen right now is if reresolve is true below and we get EAI_AGAIN so we add it back to pending_queries_.
There was a problem hiding this comment.
it's currently possible to start a resolve and cancel before it gets popped from the queue at which point we'll do the resolve anyway. doubt it matters but wanted it guarded just in case.
alyssawilk
commented
Mar 27, 2024
| @@ -157,6 +159,9 @@ class GetAddrInfoDnsResolver : public DnsResolver, public Logger::Loggable<Logge | |||
|
|
|||
| next_query = std::move(pending_queries_.front()); | |||
| pending_queries_.pop_front(); | |||
| if (reresolve && next_query->cancelled_) { | |||
There was a problem hiding this comment.
it's currently possible to start a resolve and cancel before it gets popped from the queue at which point we'll do the resolve anyway. doubt it matters but wanted it guarded just in case.
Signed-off-by: Alyssa Wilk <[email protected]>
mattklein123
approved these changes
Mar 27, 2024
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Mar 27, 2024
This reverts commit 7f6df24. Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
added a commit
that referenced
this pull request
Mar 27, 2024
This reverts commit 7f6df24. Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 3, 2024
…yproxy#33159) This reverts commit d59eb55. Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
added a commit
that referenced
this pull request
Apr 4, 2024
* Reapply "getaddrinfo: retrying on eai_again (#33130)" (#33159) Risk Level: low Testing: new tests Docs Changes: n/a Release Notes: inline [Optional Runtime guard:] yes Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
Risk Level: low Testing: new tests Docs Changes: n/a Release Notes: inline [Optional Runtime guard:] yes Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
…proxy#33159) This reverts commit 7f6df24. Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
* Reapply "getaddrinfo: retrying on eai_again (envoyproxy#33130)" (envoyproxy#33159) Risk Level: low Testing: new tests Docs Changes: n/a Release Notes: inline [Optional Runtime guard:] yes Signed-off-by: Alyssa Wilk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: low
Testing: new tests
Docs Changes: n/a
Release Notes: inline
[Optional Runtime guard:] yes