Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ext_authz fuzzer for the http client #32973

Closed

Conversation

antoniovleonti
Copy link
Contributor

@antoniovleonti antoniovleonti commented Mar 19, 2024

Commit Message: Add a ext_authz fuzzer for the http client
Additional Description: This PR creates a new fuzzer under the ext_authz directory that uses the ext_authz http client. It moves shared code between the new http fuzzer and the existing grpc fuzzer into a fuzzer utils library.
I also "smuggled in" some tiny improvements to the ext_authz code where I found some redundant copies of shared_ptr variables.
Risk Level: n/a
Testing: test-only PR
Docs Changes: none
Release Notes: none
Platform Specific Features: none
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Antonio Leonti <[email protected]>
Signed-off-by: Antonio Leonti <[email protected]>
Signed-off-by: Antonio Leonti <[email protected]>
Signed-off-by: Antonio Leonti <[email protected]>
Signed-off-by: Antonio Leonti <[email protected]>
@antoniovleonti
Copy link
Contributor Author

Half the commits in this PR are already merged into main. This is because I started working on this PR before #32859 was finished. I tried to remove them, but I don't know how nor do I know if it matters.

@antoniovleonti
Copy link
Contributor Author

/retest

1 similar comment
@antoniovleonti
Copy link
Contributor Author

/retest

@htuch
Copy link
Member

htuch commented Mar 20, 2024

@yanjunxiang-google can you take a first pass? @ggreenway can provide senior maintainer coverage and owner. CC @tyxia

@yanjunxiang-google
Copy link
Contributor

Half the commits in this PR are already merged into main. This is because I started working on this PR before #32859 was finished. I tried to remove them, but I don't know how nor do I know if it matters.

It's hard to review a PR with changes already merged into main. Maybe you can create a fresh git workspace and a fresh child branch, and just have your new changes there then send out a PR for it? That will help us to understand what's changed.

@antoniovleonti
Copy link
Contributor Author

Attempting to clean up commit history with another PR as Yanjun said.

@antoniovleonti antoniovleonti deleted the http-coverage-rebased branch May 9, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants