Extend ext_authz fuzzer coverage to grpc client #32859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Leonti <[email protected]>
|
/assign @yanjunxiang-google |
Signed-off-by: Antonio Leonti <[email protected]>
|
/assign @ggreenway |
ggreenway
previously approved these changes
Mar 13, 2024
Signed-off-by: Antonio Leonti <[email protected]>
Signed-off-by: Antonio Leonti <[email protected]>
Signed-off-by: Antonio Leonti <[email protected]>
Signed-off-by: Antonio Leonti <[email protected]>
Signed-off-by: Antonio Leonti <[email protected]>
Signed-off-by: Antonio Leonti <[email protected]>
|
/lgtm |
|
please specify a single label can be specified |
Signed-off-by: Antonio Leonti <[email protected]>
yanjunxiang-google
approved these changes
Mar 14, 2024
|
@ggreenway I think it might be waiting on you now? |
ggreenway
previously approved these changes
Mar 15, 2024
Signed-off-by: Antonio V. Leonti <[email protected]>
|
This PR was approved by Greg, so enabling auto-merge. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Extend ext_authz fuzzer coverage to grpc client
Additional Description: Previously, the ext_authz fuzzer just used a mock client. This PR replaces the mock client with a real grpc client (which makes mock grpc calls) to extend the fuzzer coverage.
This PR also removes the static qualifier of the
mocksobject as this increases the cognitive load of making changes to the fuzzer.Risk Level: None
Testing: Test-only change
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a