Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump slack-sdk from 3.22.0 to 3.23.0 in /.github… #30043

Closed
wants to merge 1 commit into from

Conversation

alyssawilk
Copy link
Contributor

…/actions/pr_notifier (#29941)"

This reverts commit 2e52759.

Revert "build(deps): bump urllib3 from 1.26.6 to 1.26.17 in /.github/actions/pr_notifier (#29913)"

This reverts commit 2d7e455.

Revert " notifier: adding basic oncall notifications (#29820)"

This reverts commit c495291.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…/actions/pr_notifier (envoyproxy#29941)"

This reverts commit 2e52759.

Revert "build(deps): bump urllib3 from 1.26.6 to 1.26.17 in /.github/actions/pr_notifier (envoyproxy#29913)"

This reverts commit 2d7e455.

Revert " notifier: adding basic oncall notifications (envoyproxy#29820)"

This reverts commit c495291.
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 9, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #30043 was opened by alyssawilk.

see: more, trace.

@alyssawilk
Copy link
Contributor Author

https://github.com/envoyproxy/envoy/actions/runs/6388884685/job/17339434685

I can't figure out how to get this to work locally, so rolling back for now

@phlax
Copy link
Member

phlax commented Oct 9, 2023

Revert "build(deps): bump urllib3 from 1.26.6 to 1.26.17 in /.github/actions/pr_notifier (#29913)"

this contains a security fix - what needs to be reverted ?

@alyssawilk alyssawilk closed this Oct 9, 2023
@alyssawilk
Copy link
Contributor Author

reverted in favor of #30044

@alyssawilk alyssawilk deleted the rollback branch March 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants