Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifier: adding basic oncall notifications #29820

Merged
merged 6 commits into from
Oct 2, 2023
Merged

notifier: adding basic oncall notifications #29820

merged 6 commits into from
Oct 2, 2023

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Sep 26, 2023 •
edited
Loading

Since slack google calendar support is deprecated, adding it back in via the PR notifier.
(theoretically) notifying general and oncall of rotation switches. This won't work (but will post that it doesn't work) if we do overrides incorrectly.

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #29820 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk marked this pull request as ready for review September 27, 2023 12:39
@alyssawilk
Copy link
Contributor Author

@phlax per usual sorry for my python
code is ready for review but PR is not ready to submit - I haven't updated the requirements and I'm not sure how to test that I've added them correctly. can you clue me in?

@alyssawilk
in without txt
ef9fdba 
Signed-off-by: Alyssa Wilk <[email protected]>
@alyssawilk
Copy link
Contributor Author

ah, progress, found the in file, trying to figure out why I can't run pip-compile to fix the txt

@phlax
Copy link
Member

phlax commented Sep 27, 2023

pip-compile to fix the txt

$ pip install pip-tools
$ cd $DIR_CONTAINING_REQS
$ pip-compile --generate-hashes --reuse-hashes --allow-unsafe requirements.in

@alyssawilk
hashes!
41bc558 
Signed-off-by: Alyssa Wilk <[email protected]>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 27, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #29820 was synchronize by alyssawilk.

see: more, trace.

@alyssawilk
Copy link
Contributor Author

yeah for some reason installing pip-compile didn't work. possibly python versioning, possibly google internal weirdness
python -m piptools compile --generate-hashes worked well enough with some minor differences I think I've cleaned up

@alyssawilk
Copy link
Contributor Author

Eventual plan follow-up: associating opsgenie names with slack names so we can ping ocall from both envoy-maintainers and envoy-CI the week of rotation, and also pinging next-oncall the week before to give them a heads up rotaton will switch to them

@alyssawilk
comments
0b11399 
Signed-off-by: Alyssa Wilk <[email protected]>
phlax
phlax previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming

NOT YET READY TO SUBMIT

is out of date

lgtm, thanks @alyssawilk

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 2, 2023
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 2, 2023
@alyssawilk
merge fix
6365380 
Signed-off-by: Alyssa Wilk <[email protected]>
@alyssawilk alyssawilk enabled auto-merge (squash) October 2, 2023 20:06
@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 2, 2023
@alyssawilk alyssawilk merged commit c495291 into envoyproxy:main Oct 2, 2023
118 of 119 checks passed
alyssawilk added a commit to alyssawilk/envoy that referenced this pull request Oct 9, 2023
@alyssawilk
Revert "build(deps): bump slack-sdk from 3.22.0 to 3.23.0 in /.github…
f3253f3 
…/actions/pr_notifier (envoyproxy#29941)"

This reverts commit 2e52759.

Revert "build(deps): bump urllib3 from 1.26.6 to 1.26.17 in /.github/actions/pr_notifier (envoyproxy#29913)"

This reverts commit 2d7e455.

Revert " notifier: adding basic oncall notifications (envoyproxy#29820)"

This reverts commit c495291.
@alyssawilk alyssawilk mentioned this pull request Oct 9, 2023
Closed
alyssawilk added a commit to alyssawilk/envoy that referenced this pull request Oct 9, 2023
@alyssawilk
UNCLEANTLY Revert " notifier: adding basic oncall notifications (envo…
75bb5be 
…yproxy#29820)"

This reverts commit c495291.

Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk added a commit that referenced this pull request Oct 9, 2023
@alyssawilk
UNCLEANTLY Revert " notifier: adding basic oncall notifications (#298… (
e419b26 
#30044)

UNCLEANLY Revert " notifier: adding basic oncall notifications (#29820)"

This reverts commit c495291.

Signed-off-by: Alyssa Wilk <[email protected]>
@alyssawilk alyssawilk deleted the announce branch March 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlax phlax phlax approved these changes

Assignees

@phlax phlax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssawilk @phlax