router: support for request/response header manipulation in weighted clusters #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clusters Signed-off-by: Stephan Zuercher <[email protected]>
|
@junr03 can you take a first pass on this? Thanks. |
junr03
reviewed
Mar 12, 2018
| request_headers_parser_(HeaderParser::configure(cluster.request_headers_to_add())), | ||
| response_headers_parser_(HeaderParser::configure(cluster.response_headers_to_add(), | ||
| cluster.response_headers_to_remove())) { | ||
| if (cluster.has_metadata_match()) { |
| {":path", "/vhost-route-and-weighted-clusters"}, | ||
| {":method", "GET"}, | ||
| }, | ||
| Http::TestHeaderMapImpl{ |
There was a problem hiding this comment.
I might be missing something in how these tests are run, but why not have the x-weighted-cluster-response-remove header here?
There was a problem hiding this comment.
It's in the previous test. You can think of these tests as existing in append/replace pairs, and I decided not to repeat the testing of header removal in the replace tests.
There was a problem hiding this comment.
Yep, I was wondering if having the remove behavior tested in both places would ensure that remove behavior works correctly regardless of adding scheme (append/replace). But if you don't think that gives us anything I am good with it.
Signed-off-by: Stephan Zuercher <[email protected]>
|
@htuch lgtm, do you mind taking a final pass? |
zuercher
added a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Mar 13, 2018
Unhide the request_headers_to_add, response_headers_to_add, and response_headers_to_remove fields in ClusterWeight. Update HTTP conn manager docs related to same. Doc update for envoyproxy/envoy#2765. Signed-off-by: Stephan Zuercher [email protected]
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
…2765) * fix(stackdriver): use more appropriate buckets for bytes Signed-off-by: Douglas Reid <[email protected]> * update buckets Signed-off-by: Douglas Reid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
request_headers_to_add,response_headers_to_add, andresponse_headers_to_removefields added to weighted clusters by envoyproxy/data-plane-api#441.Risk Level: Low - no change in behavior without configuration changes
Testing: unit and integration tests
Docs Changes: envoyproxy/data-plane-api#531
Release Notes: updated
Fixes: #2455
Signed-off-by: Stephan Zuercher [email protected]