Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: weighted cluster route manipulation #531

Merged

Conversation

zuercher
Copy link
Member

@zuercher zuercher commented Mar 8, 2018

Unhide the request_headers_to_add, response_headers_to_add, and response_headers_to_remove fields in ClusterWeight. Update HTTP conn manager docs related to same.

Doc update for envoyproxy/envoy#2765.

Signed-off-by: Stephan Zuercher [email protected]

htuch
htuch previously approved these changes Mar 8, 2018
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@htuch
Copy link
Member

htuch commented Mar 8, 2018

@zuercher docs build fails.

Signed-off-by: Stephan Zuercher <[email protected]>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge when Envoy-side PR merges.

zuercher added a commit to envoyproxy/envoy that referenced this pull request Mar 13, 2018
…clusters (#2765)

Implements the request_headers_to_add, response_headers_to_add, and response_headers_to_remove fields added to weighted clusters by envoyproxy/data-plane-api#441.

Risk Level: Low - no change in behavior without configuration changes

Testing: unit and integration tests

Docs Changes: envoyproxy/data-plane-api#531

Release Notes: updated

Fixes: #2455

Signed-off-by: Stephan Zuercher [email protected]
@zuercher zuercher merged commit 0be1aa4 into envoyproxy:master Mar 13, 2018
@zuercher zuercher deleted the stephan/weighted-cluster-header-manip branch March 13, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants