stats: add lint error for using Stats::ScopePtr, and mark that nickname as deprecated #20896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eprecated. Signed-off-by: Joshua Marantz <[email protected]>
Signed-off-by: Joshua Marantz <[email protected]>
Signed-off-by: Joshua Marantz <[email protected]>
jmarantz
changed the title
|
/retest |
|
Retrying Azure Pipelines: |
KBaichoo
approved these changes
Apr 20, 2022
| @@ -35,7 +35,7 @@ using ScopeSharedPtr = std::shared_ptr<Scope>; | |||
| // ScopePtr. We should fully remove this alias in a future PR and change all the | |||
| // references, once known consumers that might break from this change have a | |||
| // chance to do the global replace in their own repos. | |||
| using ScopePtr = ScopeSharedPtr; | |||
| using ScopePtr ABSL_DEPRECATED("Use ScopeSharedPtr() instead.") = ScopeSharedPtr; | |||
There was a problem hiding this comment.
Do we have a timeline / a tracking issue for when we'll finally get rid of this?
There was a problem hiding this comment.
#20911. I'll submit this first to get the lint check online before any other refs show up .. then I'll add a ref to that issue here.
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Apr 26, 2022
- Update the ENVOY_COMMIT and ENVOY_SHA in [bazel/repositories.bzl](https://github.com/envoyproxy/nighthawk/blob/main/bazel/repositories.bzl) to the latest Envoy's commit. - Log the value when failed to record value into HdrHistogram. - Replace `Stats::ScopePtr` with preferred term `Stats::ScopeSharedPtr`. This was introduced into format check by envoyproxy/envoy#20896. Signed-off-by: jiajunye [[email protected]](mailto:[email protected])
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…me as deprecated (envoyproxy#20896) Commit Message: Prevent further in-repo uses of Stats::ScopePtr with a lint error. Attempt to discourage out-of-repo uses of Stats::ScopePtr with a deprecated flag, though that doesn't seem to cause any warning in our build or clang-tidy when I change a reference in the code. See envoyproxy#19468 for the change to suppress deprecation warnings. Additional Description: Risk Level: low Testing: //test/common/stats/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Joshua Marantz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Prevent further in-repo uses of Stats::ScopePtr with a lint error. Attempt to discourage out-of-repo uses of Stats::ScopePtr with a
deprecatedflag, though that doesn't seem to cause any warning in our build or clang-tidy when I change a reference in the code. See #19468 for the change to suppress deprecation warnings.Additional Description:
Risk Level: low
Testing: //test/common/stats/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a