tools: not warning about deprecated declarations #19468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
lizan
reviewed
Jan 10, 2022
.bazelrc
Outdated
| @@ -41,6 +41,7 @@ build --action_env=CC | |||
| build --action_env=CXX | |||
| build --action_env=LLVM_CONFIG | |||
| build --action_env=PATH | |||
| build --copt=-Wno-deprecated-declarations | |||
There was a problem hiding this comment.
this need to be in build:linux block above to not break windows.
|
if only we could find a solution to bazelbuild/bazel#7157 - we could really clean up ci logs |
Signed-off-by: Alyssa Wilk <[email protected]>
|
oh thanks for the link @phlax - I'll ping internally and see if I can get any traction. |
|
lizan anything else you'd like to see here? |
lizan
approved these changes
Jan 13, 2022
mum4k
added a commit
to mum4k/nighthawk
that referenced
this pull request
Jan 19, 2022
- syncing `.bazelrc` from Envoy (envoyproxy/envoy#19468). - no changes in `.bazelversion`, `run_envoy_docker.sh`, `gen_compilation_database.py`. Signed-off-by: Jakub Sobon <[email protected]>
dubious90
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Jan 20, 2022
- syncing `.bazelrc` from Envoy (envoyproxy/envoy#19468). - no changes in `.bazelversion`, `run_envoy_docker.sh`, `gen_compilation_database.py`. Signed-off-by: Jakub Sobon <[email protected]>
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
Also removing a couple of unnecessary validate.proto files. This removes several thousands of lines worth of warnings from our build logs. Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: Josh Perry <[email protected]>
jmarantz
added a commit
that referenced
this pull request
Apr 20, 2022
…me as deprecated (#20896) Commit Message: Prevent further in-repo uses of Stats::ScopePtr with a lint error. Attempt to discourage out-of-repo uses of Stats::ScopePtr with a deprecated flag, though that doesn't seem to cause any warning in our build or clang-tidy when I change a reference in the code. See #19468 for the change to suppress deprecation warnings. Additional Description: Risk Level: low Testing: //test/common/stats/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Joshua Marantz <[email protected]>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…me as deprecated (envoyproxy#20896) Commit Message: Prevent further in-repo uses of Stats::ScopePtr with a lint error. Attempt to discourage out-of-repo uses of Stats::ScopePtr with a deprecated flag, though that doesn't seem to cause any warning in our build or clang-tidy when I change a reference in the code. See envoyproxy#19468 for the change to suppress deprecation warnings. Additional Description: Risk Level: low Testing: //test/common/stats/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Joshua Marantz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removing a couple of unnecessary validate.proto files.
This removes several thousands of lines worth of warnings from our build logs.