bazel: update rules_foreign_cc #18174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
keith
force-pushed
the
ks/bazel-update-rules_foreign_cc
branch
2 times, most recently
from
1bf9fa9 to
49b22d1
Compare
|
Ok this is ready now, updated the description with the reasoning |
moderation
reviewed
Sep 22, 2021
moderation
reviewed
Sep 22, 2021
moderation
reviewed
Sep 22, 2021
There was a problem hiding this comment.
@keith do you want to bump to the latest commit or do that in follow up?
This reverts commit 7760bc0. Signed-off-by: Keith Smiley <[email protected]>
keith
force-pushed
the
ks/bazel-update-rules_foreign_cc
branch
from
49b22d1 to
9c10f8c
Compare
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
|
@keith there are so many reverts and reverts-of-reverts that my brain (and probably any other newcomer) is unable to process. Can you give a summary for posterity of how we got into the situation that we had so many reverts? What's the future for this? |
|
I've updated the description with the original justification, as well as the revert history. The red CI appears to be unrelated |
|
/retest |
|
Retrying Azure Pipelines: |
htuch
approved these changes
Sep 23, 2021
|
totally, I submitted envoyproxy/envoy-mobile#1831 for discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is required for this commit
bazel-contrib/rules_foreign_cc@c41020e
in order to support Apple Silicon. Since our last update there have been
some breaking API changes. I followed these instructions to migrate:
https://github.com/bazelbuild/rules_foreign_cc/releases/tag/0.3.0
https://github.com/bazelbuild/rules_foreign_cc/releases/tag/0.4.0
This was reverted once because of a regression fixed by bazel-contrib/rules_foreign_cc@da8952e
It was reverted again because we saw a failure on envoy-mobile, but that issue turned out to be a configuration issue there, not the fault of this change. bazel-contrib/rules_foreign_cc#789 provides a better error for that case in the future, but isn't required
This reverts commit 7760bc0.
Signed-off-by: Keith Smiley [email protected]