Improve failed exports logic #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If something is misconfigured in your setup, these commands can fail. Example: ``` xcodebuild: error: SDK "iphonesimulator14.4" cannot be located. xcodebuild: error: SDK "iphonesimulator14.4" cannot be located. xcrun: error: unable to lookup item 'Path' in SDK 'iphonesimulator14.4 ``` In this case, because the execution of the command, and the `export`, were in the statement, bash ignores the exit code. This breaks that up. We could also break this up with: ``` foo=$(...) export foo ``` But that doesn't work in the postprocessing currently done with exports.
|
Nice! Is there some kind of regression test we can add? Or is this dependent upon a particular host (mis)configuration? |
|
It's dependent on host misconfiguration realistically |
|
Theoretically we could spin up a specific test job and pass some invalid value and make sure it fails, but probably too much overhead |
|
If you could add a comment about why this pattern is important, I'd be happy to get this in 😀 |
|
Updated with a link to the shellcheck details |
|
thanks! |
htuch
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Sep 23, 2021
This update is required for this commit bazel-contrib/rules_foreign_cc@c41020e in order to support Apple Silicon. Since our last update there have been some breaking API changes. I followed these instructions to migrate: https://github.com/bazelbuild/rules_foreign_cc/releases/tag/0.3.0 https://github.com/bazelbuild/rules_foreign_cc/releases/tag/0.4.0 This was reverted once because of a regression fixed by bazel-contrib/rules_foreign_cc@da8952e It was reverted again because we saw a failure on envoy-mobile, but that issue turned out to be a configuration issue there, not the fault of this change. bazel-contrib/rules_foreign_cc#789 provides a better error for that case in the future, but isn't required This reverts commit 7760bc0. Signed-off-by: Keith Smiley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If something is misconfigured in your setup, these commands can fail.
Example:
In this case, because the execution of the command, and the
export,were in the statement, bash ignores the exit code. This breaks that up.
We could also break this up with:
But that doesn't work in the postprocessing currently done with exports.