Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JwtAuthn: support completing padding on forward jwt payload header #16752

Merged
merged 12 commits into from
Jul 2, 2021

Conversation

TAOXUY
Copy link
Contributor

@TAOXUY TAOXUY commented Jun 1, 2021

Signed-off-by: Xuyang Tao [email protected]

Commit Message: revert back #16576 with adding option in filter API to enable the feature. Fix #16528
Risk Level: Low
Testing: Yes
Docs Changes: Yes
Release Notes: Yes

Signed-off-by: Xuyang Tao <[email protected]>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #16752 was opened by TAOXUY.

see: more, trace.

Signed-off-by: Xuyang Tao <[email protected]>
@TAOXUY
Copy link
Contributor Author

TAOXUY commented Jun 1, 2021

@qiwzhang

Signed-off-by: Xuyang Tao <[email protected]>
docs/root/version_history/current.rst Outdated Show resolved Hide resolved
docs/root/version_history/current.rst Outdated Show resolved Hide resolved
TAOXUY added 4 commits June 5, 2021 16:03
Signed-off-by: Xuyang Tao <[email protected]>
# Conflicts:
Merge main

Signed-off-by: Xuyang Tao <[email protected]>
Signed-off-by: Xuyang Tao <[email protected]>
Signed-off-by: Xuyang Tao <[email protected]>
qiwzhang
qiwzhang previously approved these changes Jun 7, 2021
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!
Left a few API comments.

Signed-off-by: Xuyang Tao <[email protected]>
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of API suggestions.

Signed-off-by: Xuyang Tao <[email protected]>
@TAOXUY TAOXUY force-pushed the padding-by-option branch from ccd1eca to e65edc9 Compare June 9, 2021 04:58
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@repokitteh-read-only repokitteh-read-only bot removed the api label Jun 9, 2021
Signed-off-by: Xuyang Tao <[email protected]>
Signed-off-by: Xuyang Tao <[email protected]>
@adisuissa
Copy link
Contributor

/lgtm api

@TAOXUY
Copy link
Contributor Author

TAOXUY commented Jun 10, 2021

@lizan @qiwzhang Please take a look and merge this PR.

qiwzhang
qiwzhang previously approved these changes Jun 10, 2021
source/common/common/base64.cc Outdated Show resolved Hide resolved
Signed-off-by: Xuyang Tao <[email protected]>
@TAOXUY
Copy link
Contributor Author

TAOXUY commented Jun 30, 2021

Hi @lizan, PTAL. I think the test is flaky.

@mattklein123 mattklein123 merged commit 5694726 into envoyproxy:main Jul 2, 2021
baojr added a commit to baojr/envoy that referenced this pull request Jul 7, 2021
* main:
  listener: match rebalancer to listener IP family type (envoyproxy#16914)
  jwt_authn: implementation of www-authenticate header (envoyproxy#16216)
  listener: reset the file event in framework instead of listener filter doing itself (envoyproxy#17227)
  Small typo fix (envoyproxy#17247)
  Doc: Clarify request/response attributes are http-only (envoyproxy#17204)
  bazel/README.md: add aspell comment (envoyproxy#17072)
  docs: Fix broken URL links in HTTP upgrades doc (envoyproxy#17225)
  remove the wrong comment on test (envoyproxy#17233)
  upstream: allow clusters to skip waiting on warmup for initialization (envoyproxy#17179)
  JwtAuthn: support completing padding on forward jwt payload header (envoyproxy#16752)
  remove support for v2 UNSUPPORTED_REST_LEGACY (envoyproxy#16968)
  metrics service: fix wrong argument arrange on MetricsServiceSink (envoyproxy#17127)
  deps: update cel-cpp to 0.6.1 (envoyproxy#16293)
  Add ability to filter ConfigDump. (envoyproxy#16774)
  examples: fix Wasm example. (envoyproxy#17218)
  upstream: update host's socket factory when metadata is updated. (envoyproxy#16708)

Signed-off-by: Garrett Bourg <[email protected]>
chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jwt_authn: breaking change in payload encoding
5 participants