Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update cel-cpp to 0.6.1 #16293

Merged
merged 16 commits into from
Jul 2, 2021
Merged

deps: update cel-cpp to 0.6.1 #16293

merged 16 commits into from
Jul 2, 2021

Conversation

kyessenov
Copy link
Contributor

@kyessenov kyessenov commented May 3, 2021 •
edited
Loading

Signed-off-by: Kuat Yessenov [email protected]

Commit Message: update CEL evaluator to latest release
Risk Level: low
Testing: unit / regression
Docs Changes: none
Release Notes: none

@kyessenov
deps: update cel-cpp to 0.5.0
c42112b 
Signed-off-by: Kuat Yessenov <[email protected]>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 3, 2021
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16293 was opened by kyessenov.

see: more, trace.

@kyessenov
update abseil as well
1572f09 
Signed-off-by: Kuat Yessenov <[email protected]>
moderation
moderation suggested changes May 4, 2021
View reviewed changes
Copy link
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be could to switch to releases for cel-cpp and abseil if possible

moderation
moderation suggested changes May 4, 2021
View reviewed changes
Copy link
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comments it would be preferable to switch to releases for both cel-cpp and abseil

@kyessenov
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

htuch
htuch previously approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label May 6, 2021
@kyessenov
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

@kyessenov
fix url
5da249c 
Signed-off-by: Kuat Yessenov <[email protected]>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 6, 2021
kyessenov added 2 commits May 6, 2021 14:06
@kyessenov
weird archive
96de9ae 
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov
juggle url
91e493d 
Signed-off-by: Kuat Yessenov <[email protected]>
@wrowe
Copy link
Contributor

wrowe commented May 20, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @wrowe.

see: more, trace.

@kyessenov
Copy link
Contributor Author

Windows compiler does not like initializing int64_t constexpr with long values, sending a patch upstream.

@moderation moderation mentioned this pull request May 26, 2021
Closed
@kyessenov kyessenov changed the title deps: update cel-cpp to 0.5.0 deps: update cel-cpp to 0.6.0 Jun 25, 2021
@kyessenov
typo
7b11f97 
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov
Copy link
Contributor Author

This might require some serious patching of cel-cpp since it assumes aliased string_views when using protobuf. Sigh.

@htuch
Copy link
Member

htuch commented Jun 27, 2021

@kyessenov is there any way to avoid Envoy-side patches? We're really trying to avoid these going forward.

@kyessenov
Copy link
Contributor Author

@htuch Yes, it can be fixed upstream. It's difficult to enforce in g3, so it just needs regular maintenance to ensure abseil-protobuf use is valid with non-aliased absl and std string_views.

@kyessenov kyessenov changed the title deps: update cel-cpp to 0.6.0 deps: update cel-cpp to 0.6.1 Jun 28, 2021
kyessenov added 2 commits June 28, 2021 09:25
@kyessenov
bump
874027d 
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov
fix date
a6a111c 
Signed-off-by: Kuat Yessenov <[email protected]>
@wrowe
Copy link
Contributor

wrowe commented Jun 28, 2021

Thank you for identifying the ambiguous long vs int64 issue. Awaiting cleaning up format check

@kyessenov
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

@kyessenov
Copy link
Contributor Author

The coverage dropped by 0.1% because of dependency upgrade? That is unexpected.

@kyessenov
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

@kyessenov
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

wrowe
wrowe approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@wrowe wrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM /deps ... Unconcerned about third party code coverage

@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jun 30, 2021
@htuch htuch removed their assignment Jul 1, 2021
@kyessenov
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

@kyessenov
Copy link
Contributor Author

Yay, took 2 months on-off but finally ready!

@mattklein123 mattklein123 merged commit 4071923 into envoyproxy:main Jul 2, 2021
baojr added a commit to baojr/envoy that referenced this pull request Jul 7, 2021
@baojr
Merge branch 'main' into baojr/grpc-reverse-bridge-stream
2a09e60 
* main:
  listener: match rebalancer to listener IP family type (envoyproxy#16914)
  jwt_authn: implementation of www-authenticate header (envoyproxy#16216)
  listener: reset the file event in framework instead of listener filter doing itself (envoyproxy#17227)
  Small typo fix (envoyproxy#17247)
  Doc: Clarify request/response attributes are http-only (envoyproxy#17204)
  bazel/README.md: add aspell comment (envoyproxy#17072)
  docs: Fix broken URL links in HTTP upgrades doc (envoyproxy#17225)
  remove the wrong comment on test (envoyproxy#17233)
  upstream: allow clusters to skip waiting on warmup for initialization (envoyproxy#17179)
  JwtAuthn: support completing padding on forward jwt payload header (envoyproxy#16752)
  remove support for v2 UNSUPPORTED_REST_LEGACY (envoyproxy#16968)
  metrics service: fix wrong argument arrange on MetricsServiceSink (envoyproxy#17127)
  deps: update cel-cpp to 0.6.1 (envoyproxy#16293)
  Add ability to filter ConfigDump. (envoyproxy#16774)
  examples: fix Wasm example. (envoyproxy#17218)
  upstream: update host's socket factory when metadata is updated. (envoyproxy#16708)

Signed-off-by: Garrett Bourg <[email protected]>
chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021
@kyessenov @chrisxrepo
deps: update cel-cpp to 0.6.1 (envoyproxy#16293)
a82aa77 
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: chris.xin <[email protected]>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
@kyessenov
deps: update cel-cpp to 0.6.1 (envoyproxy#16293)
5de388e 
Signed-off-by: Kuat Yessenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moderation moderation moderation requested changes

@wrowe wrowe wrowe approved these changes

@htuch htuch htuch left review comments

Assignees

@wrowe wrowe

@moderation moderation

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kyessenov @wrowe @htuch @moderation @mattklein123 @alyssawilk