Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match parameter names in method's definition and declaration #13616

Merged
merged 1 commit into from
Oct 17, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,10 @@ class ClientConfig {

private:
static MatcherSharedPtr
toRequestMatchers(const envoy::type::matcher::v3::ListStringMatcher& matcher);
toRequestMatchers(const envoy::type::matcher::v3::ListStringMatcher& list);
static MatcherSharedPtr toClientMatchers(const envoy::type::matcher::v3::ListStringMatcher& list);
static MatcherSharedPtr
toClientMatchers(const envoy::type::matcher::v3::ListStringMatcher& matcher);
static MatcherSharedPtr
toUpstreamMatchers(const envoy::type::matcher::v3::ListStringMatcher& matcher);
toUpstreamMatchers(const envoy::type::matcher::v3::ListStringMatcher& list);

const MatcherSharedPtr request_header_matchers_;
const MatcherSharedPtr client_header_matchers_;
Expand Down