Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match parameter names in method's definition and declaration #13616

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Match parameter names in method's definition and declaration #13616

merged 1 commit into from
Oct 17, 2020

Conversation

yanavlasov
Copy link
Contributor

Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Yan Avlasov [email protected]

@yanavlasov yanavlasov requested a review from dio as a code owner October 17, 2020 02:26
dio
dio approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 6826292 into envoyproxy:master Oct 17, 2020
@yanavlasov yanavlasov deleted the fix-naming branch February 1, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dio dio dio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanavlasov @dio @mattklein123