-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Fixes UDS integration & caches socket domain #13123
Conversation
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
cc: @envoyproxy/windows-dev |
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
/wait For defaults resolution |
@wrowe marking it as a draft to query some full builds in the CI to figure out which consumers are setting the default value for |
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
@wrowe i expect the ci to go green and it should be ready for review |
Signed-off-by: Sotiris Nanopoulos <[email protected]>
|
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@envoyproxy/senior-maintainers can I also get a review from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small comments, thanks.
/wait
Signed-off-by: Sotiris Nanopoulos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks like
and working in simplifying the |
If it forces it and is a bug in the formatter don't worry about it. |
Actually it is easy to fix if you simplify the functions above so it might be an overall win. I just transformed the Verifying my changes and pushing another commit |
…ddressFromHeader Signed-off-by: Sotiris Nanopoulos <[email protected]>
WDYT of the changes in 509d1c3? Locally it fixes my |
/retest |
Retrying Azure Pipelines, to retry CircleCI checks, use |
/retest |
Retrying Azure Pipelines, to retry CircleCI checks, use |
Signed-off-by: Sotiris Nanopoulos <[email protected]>
@mattklein123 the CI is all green again. feel free to take a look at the last 2 commits when you get some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice cleanup!
Commit Message:
The PR aims to fix UDS integration tests on Windows. To that end the following changes were made:
domain
function usage on Windows by caching the domain from the socket creation and passing down to the io_handler.Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A