address PR comments

Signed-off-by: Sotiris Nanopoulos <[email protected]>
envoyproxy · Sep 21, 2020 · c1d4d36 · c1d4d36
1 parent 172494e
commit c1d4d36
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/source/common/network/io_socket_handle_impl.cc b/source/common/network/io_socket_handle_impl.cc
@@ -214,7 +214,7 @@ Address::InstanceConstSharedPtr maybeGetDstAddressFromHeader(const cmsghdr& cmsg
     return getAddressFromSockAddrOrDie(ss, sizeof(sockaddr_in), fd);
   }
   return nullptr;
-} // namespace Network
+}
 
 absl::optional<uint32_t> maybeGetPacketsDroppedFromHeader(
 #ifdef SO_RXQ_OVFL
@@ -226,7 +226,7 @@ absl::optional<uint32_t> maybeGetPacketsDroppedFromHeader(
     const cmsghdr&) {
 #endif
   return absl::nullopt;
-} // namespace Envoy
+}
 
 Api::IoCallUint64Result IoSocketHandleImpl::recvmsg(Buffer::RawSlice* slices,
                                                     const uint64_t num_slice, uint32_t self_port,

diff --git a/source/common/network/io_socket_handle_impl.h b/source/common/network/io_socket_handle_impl.h
@@ -86,7 +86,7 @@ class IoSocketHandleImpl : public IoHandle, protected Logger::Loggable<Logger::I
 
   os_fd_t fd_;
   int socket_v6only_{false};
-  absl::optional<int> domain_;
+  const absl::optional<int> domain_;
 
   // The minimum cmsg buffer size to filled in destination address, packets dropped and gso
   // size when receiving a packet. It is possible for a received packet to contain both IPv4