Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quiche: restore quic test coverage #10047

Closed
wants to merge 6 commits into from
Closed

quiche: restore quic test coverage #10047

wants to merge 6 commits into from

Conversation

danzh2010
Copy link
Contributor

Re-enable test coverage check under source/extensions/quic_listeners/quiche

Fixes #8184

@danzh1989
restore coverage
3500839 
Signed-off-by: Dan Zhang <[email protected]>
@danzh2010
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #10047 (comment) was created by @danzh2010.

see: more, trace.

@mattklein123 mattklein123 self-assigned this Feb 13, 2020
mattklein123
mattklein123 previously approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@danzh2010
Copy link
Contributor Author

Coverage test fails with seg fault in Protocols/BufferIntegrationTest.RouterRequestPopulateContentLengthOnTrailers/IPv4_Http2Downstream_HttpUpstream.

@mattklein123
Copy link
Member

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #10047 (comment) was created by @mattklein123.

see: more, trace.

@mattklein123
Copy link
Member

This is now a legit coverage failure due to the coverage amount being too low.

/wait

@danzh2010
Copy link
Contributor Author

danzh2010 commented Feb 18, 2020 •
edited
Loading

Most of the coverage gap is in redundant platform implementations for QUIC, HTTP2 and Spdy. Sync's with the lasted QUICHE which moves a lot of them into shared QUICHE platform implementations. Let's see what's left after this sync.

@danzh2010
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #10047 (comment) was created by @danzh2010.

see: more, trace.

@mattklein123
Copy link
Member

Can you merge master? The coverage build should be fixed.

/wait

@danzh2010
Copy link
Contributor Author

Coverage is still lower than 97%, will add more tests.

@stale
Copy link

stale bot commented Feb 28, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 28, 2020
@stale
Copy link

stale bot commented Mar 11, 2020

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this Mar 11, 2020
@danzh2010
Copy link
Contributor Author

Can someone reopen this PR?

@mattklein123 mattklein123 reopened this Apr 27, 2020
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Apr 27, 2020
@mattklein123
Copy link
Member

@danzh2010 done

@mattklein123
Copy link
Member

Needs master merge.

/wait

@mattklein123
Copy link
Member

Looks like coverage is below threshold. :(

/wait

@stale
Copy link

stale bot commented May 6, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label May 6, 2020
@stale
Copy link

stale bot commented May 13, 2020

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 left review comments

Assignees

@mattklein123 mattklein123

Labels
stale stalebot believes this issue/PR has not been touched recently waiting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add quiche code back to coverage test
3 participants
@danzh2010 @mattklein123 @danzh1989