Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quiche code back to coverage test #8184

Closed
danzh2010 opened this issue Sep 9, 2019 · 3 comments
Closed

Add quiche code back to coverage test #8184

danzh2010 opened this issue Sep 9, 2019 · 3 comments
Labels
area/quic help wanted Needs help! quic-mvp Required for QUIC MVP tech debt

Comments

@danzh2010
Copy link
Contributor

Currently, the code under source/extensions/quic_listeners/quiche/ is excluded from coverage test in #7721. This is necessary because there are a lot of NOT_REACHED_GCOVR_EXCL_LINE, NOT_IMPLEMENTED_GCOVR_EXCL_LINE added in that PR which if included in coverage test would raise the bar of code coverage much higher than required (97%) for other PRs in the future. And also there are code hard to tests in non-integration tests.

When the integration is done, those macros should be replaced by real implementation or ASSERT with dummy tests. And integration tests should cover those currently hard-to-test lines. And we should add source/extensions/quic_listeners/quiche/ back to coverage test then.

@stale
Copy link

stale bot commented Oct 10, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 10, 2019
@stale
Copy link

stale bot commented Oct 17, 2019

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Oct 17, 2019
@danzh2010
Copy link
Contributor Author

I almost missed this issue because it is automatically closed. Can someone re-open it?

@mattklein123 mattklein123 reopened this Feb 10, 2020
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Feb 10, 2020
@ggreenway ggreenway added the quic-mvp Required for QUIC MVP label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quic help wanted Needs help! quic-mvp Required for QUIC MVP tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants