-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'abseil' into singleton
Signed-off-by: Alyssa Wilk <[email protected]>
- Loading branch information
Showing
308 changed files
with
4,072 additions
and
14,038 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,63 @@ | ||
# Process for becoming a committer | ||
# Process for becoming a maintainer | ||
|
||
## Your organization is not yet a committer | ||
## Your organization is not yet a maintainer | ||
|
||
* Express interest to the senior committers that your organization is interested in becoming a | ||
committer. Becoming a committer generally means that you are going to be spending substantial | ||
* Express interest to the senior maintainers that your organization is interested in becoming a | ||
maintainer. Becoming a maintainer generally means that you are going to be spending substantial | ||
time (>25%) on Envoy for the foreseeable future. You should have domain expertise and be extremely | ||
proficient in C++. Ultimately your goal is to become a senior committer that will represent your | ||
proficient in C++. Ultimately your goal is to become a senior maintainer that will represent your | ||
organization. | ||
* We will expect you to start contributing increasingly complicated PRs, under the guidance | ||
of the existing senior committers. | ||
of the existing senior maintainers. | ||
* We may ask you to do some PRs from our backlog. | ||
* As you gain experience with the code base and our standards, we will ask you to do code reviews | ||
for incoming PRs (i.e., all committers are expected to shoulder a proportional share of | ||
for incoming PRs (i.e., all maintainers are expected to shoulder a proportional share of | ||
community reviews). | ||
* After a period of approximately 2-3 months of working together and making sure we see eye to eye, | ||
the existing senior committers will confer and decide whether to grant commit status or not. We | ||
make no guarantees on the length of time this will take, but 2-3 months is the approximate | ||
the existing senior maintainers will confer and decide whether to grant maintainer status or not. | ||
We make no guarantees on the length of time this will take, but 2-3 months is the approximate | ||
goal. | ||
|
||
## Your organization is currently a committer | ||
## Your organization is currently a maintainer | ||
|
||
* First decide whether your organization really needs more people with commit access. Valid reasons | ||
are "blast radius", a large organization that is working on multiple unrelated projects, etc. | ||
* Contact a senior committer for your organization and express interest. | ||
* Start doing PRs and code reviews under the guidance of your senior committer. | ||
* After a period of 1-2 months the existing senior committers will discuss granting "standard" | ||
commit access. | ||
* "Standard" commit access can be upgraded to "senior" commit access after another 1-2 months of | ||
work and another conference of the existing senior committers. | ||
* First decide whether your organization really needs more people with maintainer access. Valid | ||
reasons are "blast radius", a large organization that is working on multiple unrelated projects, | ||
etc. | ||
* Contact a senior maintainer for your organization and express interest. | ||
* Start doing PRs and code reviews under the guidance of your senior maintainer. | ||
* After a period of 1-2 months the existing senior maintainers will discuss granting "standard" | ||
maintainer access. | ||
* "Standard" maintainer access can be upgraded to "senior" maintainer access aft | ||
|
||
## Maintainer responsibilities | ||
|
||
* Monitor email aliases. | ||
* Monitor Slack (delayed response is perfectly acceptable). | ||
* Triage GitHub issues and perform pull request reviews for other maintainers and the community. | ||
* In general continue to be willing to spend at least 25% of ones time working on Envoy (~1.25 | ||
business days per week). | ||
* Note that currently the above is performed by all maintainers in a best-effort/haphazard way. In | ||
the future we may decide to move to an "on-call" rotation. | ||
|
||
## When does a maintainer lose maintainer status | ||
|
||
If a maintainer is no longer interested or cannot perform the maintainer duties listed above, they | ||
should volunteer to be moved to emeritus status. In extreme cases this can also occur by a vote of | ||
the maintainers per the voting process below. | ||
|
||
# Conflict resolution and voting | ||
|
||
In general, we prefer that technical issues and maintainer membership are amicably worked out | ||
between the persons involved. If a dispute cannot be decided independently, the maintainers can be | ||
called in to decide an issue. If the maintainers themselves cannot decide an issue, the issue will | ||
be resolved by voting. The voting process is a simple majority in which each senior maintainer | ||
receives two votes and each normal maintainer receives one vote. | ||
|
||
# Adding new projects to the envoyproxy GitHub organization | ||
|
||
New projects will be added to the envoyproxy organization via GitHub issue discussion in one of the | ||
existing projects in the organization. Once sufficient discussion has taken place (~3-5 business | ||
days but depending on the volume of conversation), the maintainers of *the project where the issue | ||
was opened* (since different projects in the organization may have different maintainers) will | ||
decide whether the new project should be added. See the section above on voting if the maintainers | ||
cannot easily decide. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,20 @@ | ||
* See [CONTRIBUTING.md](CONTRIBUTING.md) for general contribution guidelines. | ||
* See [GOVERNANCE.md](GOVERNANCE.md) for governance guidelines. | ||
|
||
# Senior committers | ||
# Senior maintainers | ||
|
||
* Matt Klein ([mattklein123](https://github.com/mattklein123)) ([email protected]) | ||
* Harvey Tuch ([htuch](https://github.com/htuch)) ([email protected]) | ||
|
||
# Committers | ||
# Maintainers | ||
|
||
* Constance Caramanolis ([ccaraman](https://github.com/ccaraman)) ([email protected]) | ||
* Jose Nino ([junr03](https://github.com/junr03)) ([email protected]) | ||
* Dan Noé ([dnoe](https://github.com/dnoe)) ([email protected]) | ||
* Alyssa Wilk ([alyssawilk](https://github.com/alyssawilk)) ([email protected]) | ||
* Daniel Hochman ([danielhochman](https://github.com/danielhochman)) ([email protected]) | ||
|
||
# Emeritus committers | ||
# Emeritus maintainers | ||
|
||
* Roman Dzhabarov ([RomanDzhabarov](https://github.com/RomanDzhabarov)) ([email protected]) | ||
* Bill Gallagher ([wgallagher](https://github.com/wgallagher)) ([email protected]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
py_library( | ||
name = "jinja2", | ||
srcs = glob(["jinja2/**/*.py"]), | ||
visibility = ["//visibility:public"], | ||
deps = ["@com_github_pallets_markupsafe//:markupsafe"], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
py_library( | ||
name = "markupsafe", | ||
srcs = glob(["markupsafe/**/*.py"]), | ||
visibility = ["//visibility:public"], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
#!/usr/bin/env python | ||
|
||
# Quick-and-dirty Python to fetch git repository info in bazel/repository_locations.bzl. | ||
|
||
import imp | ||
import sys | ||
import subprocess as sp | ||
|
||
repolocs = imp.load_source('replocs', 'bazel/repository_locations.bzl') | ||
|
||
if __name__ == '__main__': | ||
if len(sys.argv) != 2: | ||
print 'Usage: %s <repository name>' % sys.argv[0] | ||
sys.exit(1) | ||
repo = sys.argv[1] | ||
if repo not in repolocs.REPOSITORY_LOCATIONS: | ||
print 'Unknown repository: %s' % repo | ||
sys.exit(1) | ||
repoloc = repolocs.REPOSITORY_LOCATIONS[repo] | ||
print '%s %s' % (repoloc['remote'], repoloc['commit']) |
Oops, something went wrong.