Skip to content

Commit

Permalink
bowing to the cult of pedagogy ("how many spaces after a period" -> h…
Browse files Browse the repository at this point in the history
  • Loading branch information
alyssawilk committed Nov 9, 2017
1 parent 1a8af58 commit fea701e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions source/common/singleton/threadsafe_singleton.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ namespace Envoy {
* Note that there is heavy resistence in Envoy to adding this type of singleton
* if data will persist with state changes across tests, as it becomes difficult
* to write clean unit tests if a state change in one test will persist into
* another test. Be wary of using it. A example of acceptable usage is OsSyscallsImpl,
* another test. Be wary of using it. A example of acceptable usage is OsSyscallsImpl,
* where the functions are not strictly speaking const, but affect the OS rather than the
* class itself. An example of unacceptable usage upstream would be for
* class itself. An example of unacceptable usage upstream would be for
* globally accessible stat counters, it would have the aforementioned problem
* where state "leaks" across tests.
*
Expand Down

0 comments on commit fea701e

Please sign in to comment.