Skip to content

Commit

Permalink
test: don't error if DNS message header is 0
Browse files Browse the repository at this point in the history
Signed-off-by: Mike Beaumont <[email protected]>
  • Loading branch information
michaelbeaumont committed Jul 10, 2024
1 parent 66f9f8a commit 19af5fb
Showing 1 changed file with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,6 @@ bool DnsResponseValidator::validateDnsResponseObject(DnsQueryContextPtr& context
}

context->id_ = static_cast<uint16_t>(context->header_.id);
if (context->id_ == 0) {
ENVOY_LOG(debug, "No ID in DNS Response");
return false;
}

// Almost always, we will have only one query here. Per the RFC, QDCOUNT is usually 1
context->queries_.reserve(context->header_.questions);
Expand Down

0 comments on commit 19af5fb

Please sign in to comment.