Skip to content

Commit

Permalink
dns: don't error if header id is 0
Browse files Browse the repository at this point in the history
Signed-off-by: Mike Beaumont <[email protected]>
  • Loading branch information
michaelbeaumont committed Jul 10, 2024
1 parent 0dbd441 commit 66f9f8a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions source/extensions/filters/udp/dns_filter/dns_parser.cc
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,6 @@ bool DnsMessageParser::parseDnsObject(DnsQueryContextPtr& context,
}

context->id_ = static_cast<uint16_t>(context->header_.id);
if (context->id_ == 0) {
ENVOY_LOG(debug, "No ID in DNS query");
return false;
}

// Almost always, we will have only one query here. Per the RFC, QDCOUNT is usually 1
context->queries_.reserve(context->header_.questions);
Expand Down

0 comments on commit 66f9f8a

Please sign in to comment.