Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fjarri/update synedrion #532

Closed
wants to merge 2 commits into from
Closed

Fjarri/update synedrion #532

wants to merge 2 commits into from

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Nov 27, 2023

(had to move #525 from my fork to the main repo because CircleCI sucks)

  • Fixes Move to a tagged release of synedrion, not a branch with a fix #509
  • Fixes Refactor pre protocol execution  #416
  • Public vs AccountId32 #376 is still open: even though we're using PublicKey instead of Public now, the problem still stands: we have AccountId32 and Public with identical contents.
  • VerifierWrapper was removed, PartyId now implements the necessary traits directly.
  • ProtocolMessage does not make a distinction between broadcast and direct messages anymore, since our messaging is direct-only. There is still a distinction in the protocol execution loop, but it will be removed when message bundling is implemented (see Message bundling synedrion#62)
  • Removed a check for messages sent to ourselves in the protocol loop because evidently it is now checked in protocol_transport/mod.rs
  • Generalized the three protocol loops.
  • Note that "my_idx" is not being passed anymore from the upper levels; this information is already present in the relation between the signer and the verifiers, and if the signer's key is not present among the verifiers, there will be an error on the session creation stage (synedrion::sessions::Error::Local).

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
entropy-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 0:19am

@fjarri
Copy link
Member Author

fjarri commented Nov 28, 2023

The original PR seems to have passed through CI, closing this one.

@fjarri fjarri closed this Nov 28, 2023
@fjarri fjarri deleted the fjarri/update-synedrion branch November 28, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to a tagged release of synedrion, not a branch with a fix Refactor pre protocol execution
1 participant