-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pre protocol execution #416
Comments
What do you mean by "pre protocol execution"? For the functions you mentioned, can you link the relevant places in the codebase? |
so in do_dkg, do_proactive_refresh and do_signing each require setting up a WS connection logic like open_protocal connection, getting the channels and a few others are copy pasted across these functions and can be generalized |
For more context, We could fix this either with a trait and generics or separating stuff in to common sub-functions. I think @JesseAbram said that @fjarri has some ideas about how best to do this. I could take on doing this once im done with wasm problems as im currently looking at these functions quite a bit. |
Refactor pre protocol execution steps that use similar code into reusable functions.
This is setting up the websocket connections functions like:
The text was updated successfully, but these errors were encountered: