Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gui app disposal handling and close all network connections #9579

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Frizi
Copy link
Contributor

@Frizi Frizi commented Mar 29, 2024

Pull Request Description

Fixes #8964

All GUI network connections are now closed after the application is unmounted.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Frizi Frizi added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Mar 29, 2024
Comment on lines -56 to -57
<EnsoTextInputWidget v-model="text" />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this change is about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed a component that no longer exists from stories. Just something I noticed when debugging.

@Frizi Frizi force-pushed the wip/frizi/gui-network-teardown branch from a3ca877 to e13c836 Compare April 4, 2024 12:33
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Apr 4, 2024
@mergify mergify bot merged commit 9c2d25e into develop Apr 4, 2024
35 of 37 checks passed
@mergify mergify bot deleted the wip/frizi/gui-network-teardown branch April 4, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After closing project in dashboard, we're getting repeatative connection error logs.
2 participants