Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After closing project in dashboard, we're getting repeatative connection error logs. #8964

Closed
farmaazon opened this issue Feb 5, 2024 · 3 comments · Fixed by #9579
Closed

After closing project in dashboard, we're getting repeatative connection error logs. #8964

farmaazon opened this issue Feb 5, 2024 · 3 comments · Fixed by #9579
Assignees
@Frizi
Labels
--bug Type: bug -gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Milestone
Beta Release

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Feb 5, 2024 •
edited
Loading

Looks like some connecting process is leaking.

Screenshot from 2024-01-18 10-28-48

We also get multiple "you may be a victim of scam" messages BTW. - see this comment
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Feb 5, 2024
@farmaazon farmaazon mentioned this issue Feb 5, 2024
Closed
@farmaazon farmaazon changed the title After closing project in dashboard, we're getting repeatative connection error logs (Picture 2). We also get multiple "you may be a victim of scam" messages BTW. After closing project in dashboard, we're getting repeatative connection error logs. Feb 5, 2024
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints --bug Type: bug -gui labels Feb 5, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Feb 5, 2024
@farmaazon
Copy link
Contributor Author

A comment from the old parent issue:

re: multiple "you may be a victim of scam" messages

this is intentional, otherwise it's possible that it's scrolled out of view by the time the user opens the console. it's true that usually this shouldn't happen because currently no real logging happens, but i think it's better to be on the safe side

@farmaazon farmaazon mentioned this issue Feb 5, 2024
Closed
@farmaazon farmaazon assigned vitvakatu and Frizi and unassigned vitvakatu Feb 5, 2024
@farmaazon farmaazon mentioned this issue Feb 7, 2024
Merged
3 tasks
@AdRiley AdRiley added this to the Beta Release milestone Feb 8, 2024
@Frizi Frizi moved this from 📤 Backlog to 🔧 Implementation in Issues Board Mar 25, 2024
@Frizi Frizi mentioned this issue Mar 29, 2024
Merged
5 tasks
@Frizi Frizi moved this from 🔧 Implementation to 👁️ Code review in Issues Board Apr 3, 2024
@enso-bot
Copy link

enso-bot bot commented Apr 3, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-03-27):

Progress: Added cancellation support to engine connection classes. It should be finished by 2024-03-29.

@enso-bot
Copy link

enso-bot bot commented Apr 3, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-03-29):

Progress: Implemented store teardown when closing gui app. It should be finished by 2024-03-29.

@mergify mergify bot closed this as completed in #9579 Apr 4, 2024
mergify bot pushed a commit that referenced this issue Apr 4, 2024
@Frizi
Improve gui app disposal handling and close all network connections (#…
9c2d25e 
…9579)

Fixes #8964

All GUI network connections are now closed after the application is unmounted.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Apr 4, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frizi Frizi

Labels
--bug Type: bug -gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Improve gui app disposal handling and close all network connections enso-org/enso
4 participants
@Frizi @AdRiley @farmaazon @vitvakatu