Synchronize suggestions loading after the reconnect 2 #9142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related #8689 Fixes a race between the language server SQL updating logic and the engine `DeserializeLibrarySuggestionsJob`s when the library suggestions may start loading before the database is properly cleaned up after the reconnect.
4e6
added
the
CI: No changelog needed
4e6
requested review from
JaroslavTulach,
hubertp and
Akirathan
as code owners
hubertp
approved these changes
Feb 23, 2024
|
|
||
| case msg: Api.SuggestionsDatabaseSuggestionsLoadedNotification => | ||
| logger.debug( | ||
| "Starting loading suggestions for library [{}].", | ||
| msg.libraryName | ||
| ) | ||
| context.become( |
There was a problem hiding this comment.
This change isn't strictly necessary since applyLoadedSuggestions is a Future, right?
There was a problem hiding this comment.
Yes, we need to change the state before starting loading the suggestions
| @@ -493,6 +493,9 @@ object SearchProtocol { | |||
| updates: Seq[SuggestionsDatabaseUpdate] | |||
| ) | |||
|
|
|||
| /** A request to clean the suggestions database. */ | |||
| case object CleanSuggestionsDatabase | |||
There was a problem hiding this comment.
nit: since it is a request, I'd rather we name it ClearSuggestionsDatabase
| "SuggestionsDatabaseSuggestionsLoadedNotification [shouldStartBackgroundProcessing={}].", | ||
| state.shouldStartBackgroundProcessing | ||
| ) | ||
| if (state.shouldStartBackgroundProcessing) { |
There was a problem hiding this comment.
So this was the main source of the problem?
There was a problem hiding this comment.
I had to properly synchronize the state of background notifications in runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
related #8689, #9072
Fixes a race between the language server SQL updating logic and the engine
DeserializeLibrarySuggestionsJobs when the library suggestions may start loading before the database is properly cleaned up after the reconnect.Important Notes
As a side effect, arguments are showing slightly (~1 second) faster due to the lower contention between the engine jobs.
Before
Peek.2024-02-22.16-06.mp4
After
Peek.2024-02-22.16-01.mp4
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.