-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Server breaks on page refresh. #8689
Comments
Kazam_screencast_00028.webm |
This is what I get: Screencast.from.2024-01-08.10-25-50.webmI think I don't see login screen, because I'm already logged in. You can try "continue without logging" option and then reopen same project. Logs: |
Kazam_screencast_00036.webmStill can't reproduce. When logged in. When logged out things become a bit unstable, yes. |
Hubert Plociniczak reports a new STANDUP for the provided date (2024-02-02): Progress: Added a fix for leaking FileSystemService. Apparently Next Day: Next day I will be working on the #8689 task. Continue the investigation |
Hubert Plociniczak reports a new STANDUP for yesterday (2024-02-04): Progress: Still trying to figure out the memory leaks in tests but no success so far. It should be finished by 2024-02-05. Next Day: Next day I will be working on the #8689 task. Continue the investigation |
Did more tweaks and looks like I can reproduce now. Investigating. |
Hubert Plociniczak reports a new STANDUP for yesterday (2024-02-05): Progress: Finally managed to reproduce the issue, debugging. Reviewed #8924, planning language-server work, dealing with CI hiccups. It should be finished by 2024-02-05. Next Day: Next day I will be working on the #8689 task. Continue the investigation |
Hubert Plociniczak reports a new 🔴 DELAY for yesterday (2024-02-06): Summary: There is 4 day delay in implementation of the Language Server breaks on page refresh. (#8689) task. Delay Cause: Unfamiliar with that part of the codebase + underestimated the randomness of the problem. |
Hubert Plociniczak reports a new STANDUP for yesterday (2024-02-06): Progress: No progress in debugging the issue even though it happens consistently. Consulting with Dmitry on potential reasons. It should be finished by 2024-02-09. Next Day: Next day I will be working on the #8689 task. Continue the investigation |
related #8689 Fixes the NPE during the serialization of update messages. ``` java.lang.NullPointerException: Cannot invoke "java.util.UUID.toString()" because "a" is null ```
Hubert Plociniczak reports a new STANDUP for yesterday (2024-02-07): Progress: Still investigating. Apparently it could be related to invalidating modules request, similar to #7413. It should be finished by 2024-02-09. Next Day: Next day I will be working on the #8689 task. Continue the investigation |
related #8689 Clean up the client's execution contexts when it disconnects from the language server. Dangling execution contexts may slow down the execution when the user reconnects to the language server.
Hubert Plociniczak reports a new 🔴 DELAY for today (2024-02-13): Summary: There is 5 day delay in implementation of the Language Server breaks on page refresh. (#8689) task. Delay Cause: Didn't manage to find the root of the problem before going on holiday, the problem is also tricky to identify. |
Hubert Plociniczak reports a new STANDUP for yesterday (2024-02-12): Progress: Continued investigation. Still unable to locate the root of the problem. Catching up after a break. It should be finished by 2024-02-14. Next Day: Next day I will be working on the #8689 task. Continue the investigation |
related #8689 Fixes a race between the language server SQL updating logic and the engine `DeserializeLibrarySuggestionsJob`s when the library suggestions may start loading before the database is properly cleaned up after the reconnect.
Hubert Plociniczak reports a new STANDUP for the provided date (2024-02-13): Progress: The root of the problem appears to be in the IR loaded from the cache. It looks like nodes are missing either source or UUIDs once the information is loaded on restart. This results in missing instrumentation. It should be finished by 2024-02-14. Next Day: Next day I will be working on the #8689 task. Continue the investigation |
Hubert Plociniczak reports a new STANDUP for yesterday (2024-02-14): Progress: PR with a fix is ready, turned out to be a smal problem with UUID not being serialized. Providing a test case is again problematic since it seems that we a) don't serialize ids of IRs b) don't generate UUIDs for IdentifierLocation in our tests. Various planning meetings. It should be finished by 2024-02-14. Next Day: Next day I will be working on the #8689 task. Address PR review, try to figure out a test case, if any, pick up next item on the list. |
Missing ID's in IR meant that instrumentation wouldn't be applied for loaded modules. This is the reason why after a restart engine wouldn't send **any** expression updates. Closes #8689. # Important Notes After the change [Kazam_screencast_00038.webm](https://github.com/enso-org/enso/assets/292128/4249287b-6c41-4c9d-b138-e7af59512566) The video somehow doesn't show that all nodes are loaded after the restart, but once I moved the screen they are there. This appears to be a bug in the recording somehow.
Hubert Plociniczak reports a new 🔴 DELAY for the provided date (2024-02-19): Summary: There is 4 days delay in implementation of the Language Server breaks on page refresh. (#8689) task. Delay Cause: Adding more tweaks, dealing with licensing |
related #8689 Fixes a race between the language server SQL updating logic and the engine `DeserializeLibrarySuggestionsJob`s when the library suggestions may start loading before the database is properly cleaned up after the reconnect.
related #8689, #9072 Fixes a race between the language server SQL updating logic and the engine `DeserializeLibrarySuggestionsJob`s when the library suggestions may start loading before the database is properly cleaned up after the reconnect. # Important Notes As a side effect, arguments are showing slightly (~1 second) faster due to the lower contention between the engine jobs. #### Before https://github.com/enso-org/enso/assets/357683/cbda2da4-9080-4b9b-b836-81e54694d468 #### After https://github.com/enso-org/enso/assets/357683/bf442284-47be-456d-b1dd-2413b6ad8244
To reproduce
Expected: page refreshes and loads project properly
Actual: language server reports exception, no node is colored.
The reported exception is
It always appears when the problem occurs. Here is full log from several launches, some reproducing the issue.
enso-project-manager-2024-01-05.0.log
The text was updated successfully, but these errors were encountered: