Collapsing nodes #8686
Merged
Collapsing nodes #8686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
added
CI: No changelog needed
farmaazon
requested review from
farmaazon
and removed request for
MichaelMauderer
farmaazon
approved these changes
Jan 8, 2024
Frizi
requested changes
Jan 8, 2024
Frizi
approved these changes
Jan 10, 2024
kazcw
reviewed
Jan 10, 2024
app/gui2/src/util/ast/abstract.ts
Outdated
| exprs_.push({ newline: { node: Token.new('\n') }, expression: null }) | ||
| } | ||
| const body = BodyBlock.new(exprs_, module) | ||
| const args_ = args.map((arg) => [{ node: arg.exprId }]) |
There was a problem hiding this comment.
When constructing an Ast object it's important to ensure any children are accessible in the object's module. After #8711 the makeChild helper takes care of this; it can be used like: node: makeChild(module, arg, id). id should be the ID of the object currently being constructed; it can be generated with newAstId() and used here and as the ID argument to the Function constructor call below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #8067
Also fixes
nodeRectsmap, as it no longer stores invlisible nodes.collapsing.nodes.mp4
Important Notes
Positioning of newly created nodes is not handled yet, as it requires fixes in the Ast editing API.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.