Collapsing nodes

[farmaazon]

To be done after #7863

Collapsing nodes should work exactly the same as in old GUI: https://github.com/enso-org/enso/blob/develop/app/gui/src/controller/graph.rs#L1074-L1106

[Frizi]

Alias analysis is needed to determine inputs/outputs of collapsed nodes and to insert appropriate arguments.

Only support as much as the language server currently allows (e.g. single output)

[enso-bot]

Ilya Bogdanov reports a new STANDUP for today (2023-12-25):

Progress: Understanding how new ast editing works, working on initial implementation. Unit testing is hard to implement, I might use e2e tests instead. It should be finished by 2023-12-28.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for today (2023-12-26):

Progress: Implemented collapsing (except for collapsing inside collapsed nodes) and tested it manually. It still has several issues, like not receiving method info from the engine and invalid connection info for collapsed nodes. It should be finished by 2023-12-28.

[enso-bot]

Ilya Bogdanov reports a new 🔴 DELAY for today (2024-01-03):

Summary: There is 8 days delay in implementation of the Collapsing nodes (#8067) task.
It will cause 0 days delay for the delivery of this weekly plan.

4 days are weekends and vacation, 3 days of sick leave

Delay Cause: Being sick, also fixes for corner cases required adding additional API.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for today (2024-01-03):

Progress: Finishing the implementation, working on corner cases (collapsing inside other methods, choosing a unique name for collapsed function). Found an issue with node selection mechanism that ignores execution stack. Preplanning and weekly demo calls. Need to adjust positions of newly created nodes. It should be finished by 2024-01-05.

Next Day: Next day I will be working on the same task. Opening the PR.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for yesterday (2024-01-04):

Progress: Trying to implement proper positioning for collapsed node and output node of the collapsed function. It does not seem possible with the current API, as Ast editing changes Ast IDs, and there is no way to know the ID of the newly created node in advance. The workaround suggested by Kaz didn’t work, so we decided to proceed without positioning until the issue would be fixed on the Ast API side. It should be finished by 2024-01-05.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for the provided date (2024-01-05):

Progress: Finished polishing the code and opened a PR for reviewers. Implementing proper positioning of the nodes is close to impossible with the restrictions of the current Ast editing API, so it would be postponed for a bit. Starting working on e2e tests for collapsing. It should be finished by 2024-01-05.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for the provided date (2023-12-07):

Progress: Starting copying algorithm for collapsing nodes from the old gui. It should be finished by 2024-01-05.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for the provided date (2023-12-08):

Progress: Working on collapsed nodes analysis, implementing unit tests for it. It should be finished by 2024-01-05.

[enso-bot]

Ilya Bogdanov reports a new 🔴 DELAY for the provided date (2024-01-10):

Summary: There is 5 days delay in implementation of the Collapsing nodes (#8067) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Waiting on review, other tasks in progress.

[enso-bot]

Ilya Bogdanov reports a new STANDUP for the provided date (2024-01-10):

Progress: Addressing review comments It should be finished by 2024-01-10.