Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify internal logic of Table.order_by, avoid unnecessary warning #8221

Merged

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Nov 3, 2023

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 3, 2023
@radeusgd radeusgd self-assigned this Nov 3, 2023
@radeusgd radeusgd added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Ready to merge This PR is eligible for automatic merge labels Nov 6, 2023
@radeusgd
Copy link
Member Author

radeusgd commented Nov 6, 2023

I don't seem to see a noticeable difference in performance. The new approach seems to be slightly faster, but it is within error-of-measurement range.

image

Sorting objects seems to be faster in a noticeable way.

@mergify mergify bot merged commit 237aae3 into develop Nov 6, 2023
@mergify mergify bot deleted the wip/radeusgd/8213-avoid-warning-when-ordering-by-floats branch November 6, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table.order_by should not warn about Floating_Point_Equality when sorting on Float columns
3 participants