Table.order_by should not warn about Floating_Point_Equality when sorting on Float columns

[radeusgd]

The Floating_Point_Equality warning is related to operations relying on equality - e.g. grouping. Sorting relies on ordering and the warning is irrelevant here, but apparently it is reported for order_by - this is a mistake.

After analysis, I can see it happens because we use the 'equality-oriented' MultiValueIndex which reports the Floating_Point_Equality warning, within Table::orderBy. That seems unnecessary - there is no need to create the index - we can just use List<OrderedMultiValueKey>::sort and extract the row ordering from that result.

• Add a test checking that no warnings should be reported when sorting on a Float column.
• Change Table::orderBy to use List::sort instead of the index.
• Out of curiosity, we could compare the performance of before and after.

[enso-bot]

Radosław Waśko reports a new STANDUP for the provided date (2023-11-04):

Progress: Fixed the order by issue (PR ready). Added better tests for Between and realised the current implementation fails many of them. Switched to a different implementation that is better suited. It should be finished by 2023-11-06.

Next Day: Next day I will be working on the #5303 task. Finish the new implementation of Between to make it better. Get the PR through. Start next tasks.