-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks related to add_row_number
performance investigation
#8091
Add benchmarks related to add_row_number
performance investigation
#8091
Conversation
See the relevant comment in #8090 for the Map benchmark summary. |
Comparing performance of Enso and Java multi-value-key implementations (v1)To see the performance of the basic operations of each key, we do the following:
|
Comparing performance of Enso and Java multi-value-key implementations (v2)I added another test with an Enso object with custom comparator - theoretically here Enso could have some advantage - let's see if it uses it. I also increased the warmup time temporarily to give the compiler a bit more opportunity to optimize. Ordered
Unordered
We can see that Enso seems to be around 2x slower than Java counterpart, even in the custom comparator case. Probably the polyglot boundary crossing that is happening to extract the values from the Table columns is still more painful than the cost of polyglot calls to call the custom comparator. |
Pull Request Description
add_row_number
by using the Java index instead of Enso one #8055Vector.distinct
) and replacing updates (like keeping a counter for each key). These benchmarks can be used as a metric for Improving performance ofMap.insert
#8090Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.